Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loading): 修复text为空时,实际大小与视觉大小不一致问题 #621

Merged
merged 4 commits into from
Jul 18, 2022
Merged

fix(loading): 修复text为空时,实际大小与视觉大小不一致问题 #621

merged 4 commits into from
Jul 18, 2022

Conversation

wanpan11
Copy link
Contributor

@wanpan11 wanpan11 commented Jul 16, 2022

fix #618

🤔 这个 PR 的性质是?

  • 日常 bug 修复

🔗 相关 Issue

fix(loading): 修复text为空时,实际大小与视觉大小不一致问题
#618

📝 更新日志

  • fix(Loading): 修复 text 为空时仍渲染非空节点的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

src/loading/loading.wxml Outdated Show resolved Hide resolved
src/loading/loading.wxml Outdated Show resolved Hide resolved
Copy link
Collaborator

@LeeJim LeeJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeeJim LeeJim merged commit ac74c6d into Tencent:develop Jul 18, 2022
@wanpan11 wanpan11 deleted the fix-loading-size branch July 18, 2022 07:36
@github-actions github-actions bot mentioned this pull request Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants